Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub] Add a GraphQL client to the connector #3837

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rgmz
Copy link
Contributor

@rgmz rgmz commented Jan 11, 2025

Description:

This introduces a latent GraphQL client without making any functional changes. The GraphQL API is required for certain features (e.g., #1906), and it is already being manually called in at least once place:

req, err := http.NewRequest("POST", "https://api.github.com/graphql", bytes.NewBuffer(requestBody))
if err != nil {
return nil, fmt.Errorf("failed to create request: %w", err)
}

shurcooL/githubv4 is the library recommended by the authors of google/go-github.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@rgmz rgmz requested review from a team as code owners January 11, 2025 15:10
@rgmz rgmz marked this pull request as draft January 11, 2025 15:11
@rgmz rgmz force-pushed the feat/github-graphql branch from b3fcb92 to c2bc286 Compare January 11, 2025 15:34
@rgmz rgmz marked this pull request as ready for review January 11, 2025 15:36
@rgmz rgmz force-pushed the feat/github-graphql branch 2 times, most recently from 8ef8a9d to 37ec6bc Compare January 11, 2025 15:53
@rgmz rgmz force-pushed the feat/github-graphql branch from 37ec6bc to c067504 Compare January 11, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant