Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manage extension #11

Merged
merged 7 commits into from
Nov 10, 2023
Merged

Add manage extension #11

merged 7 commits into from
Nov 10, 2023

Conversation

sosthene-nitrokey
Copy link
Collaborator

@sosthene-nitrokey sosthene-nitrokey commented Nov 9, 2023

The management extension adds support for factory-reseting an entire device. It also allows factory resetting another client.

It also allows preserving a set of files when operating a factory reset.

Copy link
Member

@robin-nitrokey robin-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One potential issue would be the separation between the privileged manage extension and the other unprivileged extensions. If we grant access to e. g. the chunking extension to a client, we don’t necessarily want it to have access to the manage extension too. But I think we should be able to fix that in the runner by assigning two backend IDs to the staging backend and only dispatching manage requests for one of them, right?

@sosthene-nitrokey sosthene-nitrokey merged commit 10baac2 into main Nov 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants