Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce re-exports #161

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Reduce re-exports #161

wants to merge 4 commits into from

Commits on Apr 3, 2024

  1. Remove unnecessary qualifications

    @robin-nitrokey
    robin-nitrokey committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    20b0acb View commit details
    Browse the repository at this point in the history

  2. Reduce wildcard imports 

    This patch removes some wildcard imports to make the dependencies
between modules clearer and to refactoring easier.
    @robin-nitrokey
    robin-nitrokey committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    83cf940 View commit details
    Browse the repository at this point in the history

  3. Reduce external re-exports 

    This patch removes all re-exports of external types as discussed
in trussed-dev#155, except for those that are essential for using Trussed:
heapless_bytes::Bytes (only from the types module) and
littlefs2::path::{Path, PathBuf}.

Also, the cbor_smol re-exports in the main module are kept until we have
a better mechanism for that.

trussed-dev#155
    @robin-nitrokey
    robin-nitrokey committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    9d2456b View commit details
    Browse the repository at this point in the history

  4. Remove internal re-exports 

    As discussed in trussed-dev#155, this patch removes re-exports from types that are
defined inside the crate.  This means that all types that are defined in
this crate are now only visible under one path.

trussed-dev#155
    @robin-nitrokey
    robin-nitrokey committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    2e4e15a View commit details
    Browse the repository at this point in the history