Add support for more elliptic curves #163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sosthene-nitrokey
commented
Apr 19, 2024
•
sosthene-nitrokey
commented
- p348 (using RustCrypto)
- p521 (using Ruscrypto)
- brainpoolP256r1 (Mechanism definition only, implementation in separate backend)
- brainpoolP384r1 (Mechanism definition only, implementation in separate backend)
- brainpoolP512r1 (Mechanism definition only, implementation in separate backend)
Remove default syscalls from default features
Older version of Rust failed to format `service.rs` file.
Run cargo fmt
Merge upstream changes
sosthene-nitrokey
force-pushed
the
more-curves
branch
from
a190f6c
to
029e7c8
Compare
Cargo.toml
Outdated
| @@ -110,6 +113,8 @@ hmac-sha1 = [] | |||
| hmac-sha256 = [] | |||
| hmac-sha512 = [] | |||
| p256 = [] | |||
| p384 = ["dep:p384"] | |||
| p521 = ["dep:p521", "ecdsa"] | |||
There was a problem hiding this comment.
Suggested change
| p521 = ["dep:p521", "ecdsa"] | |
| p521 = ["dep:p521", "dep:ecdsa"] |
sosthene-nitrokey
force-pushed
the
more-curves
branch
3 times, most recently
from
cb10d6e
to
c7a4722
Compare
sosthene-nitrokey
force-pushed
the
more-curves
branch
from
c7a4722
to
723029a
Compare
6 tasks
|
This will need to get rebased on top of trussed-main to remove the nitrokey main commits. |
5 tasks
Comment on lines
+60
to
+62
| p384 = { version = "0.13.0", optional = true, default-features = false, features = ["sha384", "ecdh", "ecdsa"] } | ||
| p521 = { version = "0.13.3", optional = true, default-features = false, features = ["sha512", "ecdh", "ecdsa"] } | ||
| ecdsa = { version = "0.16.9", optional = true, default-features = false } |
There was a problem hiding this comment.
nit: move to the RustCrypto section
|
This PR is actually the rebased version. This PR should be against the nitrokey fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.