This repository has been archived by the owner on Jan 1, 2025. It is now read-only.
update LevelDB implementation #102
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* get rid of seg fault * fix tests for indexdb and inmemory. Tests for leveldb failing to query docs * fix test blocks * add notes do debugging index problems * update gitignore --------- Signed-off-by: mix irving <mix@protozoa.nz> Co-authored-by: mixmix <mix@protozoa.nz>
mixmix
commented
Jul 15, 2024
| @@ -16,4 +16,5 @@ Object.defineProperty(globalThis, "crypto", { | |||
| }, | |||
| }); | |||
|
|
|||
| Object.assign(global, { TextDecoder, TextEncoder }); | |||
| const _TextUtils = JSON.parse(JSON.stringify({ TextDecoder, TextEncoder })) | |||
| Object.assign(global, _TextUtils) | |||
There was a problem hiding this comment.
this change fixed an error that was being thrown
mixmix
commented
Jul 19, 2024
Comment on lines
+19
to
+20
| const _TextUtils = JSON.parse(JSON.stringify({ TextDecoder, TextEncoder })) | ||
| Object.assign(global, _TextUtils) |
There was a problem hiding this comment.
@chereseeriepa if you stringify { TextEncode } you get {}
So perhaps the correct edit is:
Suggested change
| const _TextUtils = JSON.parse(JSON.stringify({ TextDecoder, TextEncoder })) | |
| Object.assign(global, _TextUtils) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the upgrade of
rxdb, we saw breaking changes hit@pluto-encrypted/leveldb.This PR
leveldbpackagetest-suite