Fix test suite #103
Fix test suite #103
Conversation
chereseeriepa
force-pushed
the
fix_master_tests_cherese
branch
from
c1bec82 to
32a5e04
Compare
chereseeriepa
force-pushed
the
fix_master_tests_cherese
branch
from
32a5e04 to
72672f0
Compare
| @@ -4,6 +4,9 @@ import { describe, it, beforeEach, afterEach } from 'vitest'; | |||
| import { runTestSuite } from '@pluto-encrypted/test-suite'; | |||
| import { createLevelDBStorage } from '../src' | |||
|
|
|||
| const SegfaultHandler = require('segfault-handler'); | |||
| import { addRxPlugin } from "rxdb"; | ||
| import { RxDBDevModePlugin } from "rxdb/plugins/dev-mode"; | ||
| import nodeCrypto from "crypto"; | ||
|
|
||
| // set up segfault handler |
| let storage: RxStorage<any, any> | ||
| let storageInstance: RxStorageInstance<RxDocType, any, any, any> | undefined | ||
| const { it, describe } = suite | ||
| // let storage: RxStorage<any, any> |
| @@ -372,6 +361,7 @@ export function testCorrectQueries<RxDocType>( | |||
| } | |||
|
|
|||
| // Test output of RxStorageInstance.query(); | |||
| // TODO: queries arent returning anything | |||
|
|
||
| await storageInstance.cleanup(Infinity) | ||
| // await storageInstance.close() |
There was a problem hiding this comment.
TODO: do we need to close each instance?
packages/test-suite/src/index.ts
Outdated
| }], | ||
| testContext | ||
| ) | ||
| await storageInstance.bulkWrite( |
| @@ -184,8 +188,16 @@ export class RxStorageIntanceLevelDB<RxDocType> implements RxStorageInstance< | |||
| upperBound | |||
| ); | |||
| const indexName = getIndexName(index); | |||
| // => '_meta.lwt,key' | |||
| // QUESTION: this doesn't seem to map to any of the indexes being entered? | |||
There was a problem hiding this comment.
We're seeing some weirdness where the queryPlan generates index name which is then used by getIndex and gets nothing ... looking at what's going in with setIndex is seems there is some mis-alignment (i.e. no indexes are being set with value _meta.lwt,key ....
Pausing here for today - the next questions are:
- why misalignment
- what should
setIndexgetIndexbe doing? (where's the definition) - ....?
There was a problem hiding this comment.
When you have a query, the storage should check if the current query is satisfied by an index and get the index instead of listing all the rows.
Its done for efficiency, the indexes are just faster to query than whole table if that makes sense.
There was a problem hiding this comment.
Yeah I know what an index is, have used them a bunch.
What I'm confused about is why the setIndex and getIndex look so wrong
Signed-off-by: mix irving <mix@protozoa.nz>
Currently, the test suite is failing to run on leveldb. This PR does the follow:
TODO: