feat: implemented OIDC presentation submission API #453
Conversation
Codecov ReportBase: 85.30% // Head: 85.30% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #453 +/- ##
=======================================
Coverage 85.30% 85.30%
=======================================
Files 14 14
Lines 1320 1320
=======================================
Hits 1126 1126
Misses 120 120
Partials 74 74 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
birtony
changed the title
birtony
force-pushed
the
issue433
branch
2 times, most recently
from
860f9f2 to
1f436c4
Compare
| } | ||
|
|
||
| const vpToken = new Object(); | ||
| Object.defineProperty(vpToken, "presentation_submission", { |
There was a problem hiding this comment.
just curious about this syntax,
Why can't
``
var vpToken = {}
vpToken. presentation_submission = presentationSubmission
``
There was a problem hiding this comment.
This way, the properties inside the vpToken object are not modifiable
There was a problem hiding this comment.
they are local fields, simply making them var type doesn't hurt.
There was a problem hiding this comment.
I cannot use this syntax to create property @context on the object, which is required for https://github.com/trustbloc/agent-sdk/pull/453/files#diff-73c781567add49e4fe09e28cea2e4f4530d4999259ce327f63a89dc043d3d68dR199
I figured it'd be better to be consistent with the approach I take
Signed-off-by: Anton Biriukov <anton.biriukov@avast.com>
| } | ||
|
|
||
| const vpToken = new Object(); | ||
| Object.defineProperty(vpToken, "presentation_submission", { |
Fixes #433
Signed-off-by: Anton Biriukov anton.biriukov@avast.com