Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do drt and rot really have a c field? #206

Open
VasiliyS opened this issue Aug 9, 2024 · 2 comments
Open

Do drt and rot really have a c field? #206

VasiliyS opened this issue Aug 9, 2024 · 2 comments

Comments

@VasiliyS
Copy link
Contributor

VasiliyS commented Aug 9, 2024

https://trustoverip.github.io/tswg-keri-specification/#delegated-rotation-event-message-body

defines the following fields: [ v, t, d, i, s, p, kt, k, nt, n, bt, br, ba, c, a].

However, keripy's implementation lacks any references to it. The same goes for the rot message.

according to: https://trustoverip.github.io/tswg-keri-specification/#configuration-traits-field, this could potentially hold RB trait (Registrar Backers).

How should implementers interpret this? Is this something that is only planned for a future revision of KERI?
Should the implementers targeting compatibility with the current vLEI ecosystem refer to the keripy for the authoritative answers then?

@VasiliyS VasiliyS changed the title Does drt really has a c field? Do drt and 'rot' really have a c field? Aug 9, 2024
@VasiliyS VasiliyS changed the title Do drt and 'rot' really have a c field? Do drt and rot really have a c field? Aug 9, 2024
@SmithSamuelM
Copy link
Contributor

The 'c' field was added for KERI version 2 for both the "rot" and "drt" messages. The specs as written are forward looking for the next version version 2 not version 1. Version 1 is the production code.

@SmithSamuelM
Copy link
Contributor

If you look more closely however you will see that one can generate version 2 key event messages that include all the version 2 fields. The Fields class variable in the Serder class in keri.core.serdering.py includes the field names for Vrsn_2_0 and you can see that both the 'rot" and "drt" messages include a 'c' field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants