[Chore]: Fix Android bindings #4095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satoshiotomakan
requested review from
vcoolish
and removed request for
ar-g and
Milerius
vcoolish
approved these changes
Nov 5, 2024
Binary size comparison➡️ aarch64-apple-ios: 12.35 MB ➡️ aarch64-apple-ios-sim: 12.36 MB ➡️ aarch64-linux-android: 16.01 MB ➡️ armv7-linux-androideabi: 13.56 MB ➡️ wasm32-unknown-emscripten: 11.30 MB |
satoshiotomakan
requested review from
JaimeToca and
rkokhatskyi
as code owners
|
Hi @satoshiotomakan, I think that if a file is missing, the compiler will throw an error. Could you share more details about why the compilation was successful before? |
|
Okay, I understand. Thanks for your explanation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing
GenericPhantomReference.javaclass.How to test
Run Native Android tests
Types of changes
Checklist
If you're adding a new blockchain