fix: Fixed 400 error when use RequestOptions.

tryAGI · May 12, 2024 · a916951 · a916951
1 parent d2fc864
commit a916951
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 1 deletion.
diff --git a/src/libs/Directory.Build.props b/src/libs/Directory.Build.props
@@ -14,7 +14,7 @@
   </ItemGroup>
 
   <PropertyGroup Label="Nuget">
-    <Version>0.9.4</Version>
+    <Version>0.9.5</Version>
     <GeneratePackageOnBuild Condition=" '$(Configuration)' == 'Release' ">true</GeneratePackageOnBuild>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <Authors>tryAGI and contributors</Authors>

diff --git a/src/libs/Ollama/OllamaApiClient.cs b/src/libs/Ollama/OllamaApiClient.cs
@@ -341,6 +341,7 @@ private async IAsyncEnumerable<TResponse> StreamPostAsync<TRequest, TResponse>(
 	}
 }
 
+[JsonSourceGenerationOptions(DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull)]
 [JsonSerializable(typeof(DeleteModelRequest))]
 [JsonSerializable(typeof(GenerateCompletionRequest))]
 [JsonSerializable(typeof(GenerateCompletionResponse))]

diff --git a/src/tests/Ollama.IntegrationTests/Tests.Integration.cs b/src/tests/Ollama.IntegrationTests/Tests.Integration.cs
@@ -78,6 +78,28 @@ public async Task PullModel()
         await container.ApiClient.PullModelAsync("nomic-embed-text").WaitAsync();
     }
 
+    [TestMethod]
+    public async Task GetCompletionWithOptions()
+    {
+#if DEBUG
+        await using var container = await PrepareEnvironmentAsync(EnvironmentType.Local, "llama3");
+#else
+        await using var container = await PrepareEnvironmentAsync(EnvironmentType.Container, "llama3");
+#endif
+
+        var response = await container.ApiClient.GetCompletionAsync(new GenerateCompletionRequest
+        {
+            Model = "llama3",
+            Prompt = "answer me just \"123\"",
+            Stream = true,
+            Options = new RequestOptions
+            {
+                Temperature = 0,
+            },
+        }).WaitAsync();
+        Console.WriteLine(response.Response);
+    }
+
     [TestMethod]
     public async Task GetCompletion()
     {