Addressing 2n WG LC comments (#294)

* Resolved idnits

* Folded YANG trees

* Added back change note on typedef te-node-id

* Fixing .gitignore issue

* Ignoring generated diff files

* Ignoring folded trees

* Addressing comments from Med

* Updated IANA considerations

* Removed change notes together with appendix B and C

* Indented all derived identities in YANG models

.gitignore

@@ -1,12 +1,14 @@
 
+*.fold
 *.swp
 ietf-mpls-static-extended.fxs
 ietf-mpls-static.fxs
 *.fxs
 rsvp_te_model.tree.folded
 rsvp_te_model.tree.save
 *.comments
-drafts/te-topo-profile/.refcache/*.*
-drafts/mpls-te-topology/.refcache/*.*
-drafts/te-types-update/.refcache/*.*
-drafts/te-types-update/diffs/*.*
+drafts/te-topo-profile/.refcache/
+drafts/mpls-te-topology/.refcache/
+drafts/te-types-update/.refcache/
+drafts/te-types-update/diffs/
+*.bash

ietf-te-packet-types.yang

@@ -65,7 +65,7 @@ module ietf-te-packet-types {
      This version of this YANG module is part of RFC XXXX
      (https://www.rfc-editor.org/info/rfcXXXX); see the RFC itself
      for full legal notices.";
-  revision 2024-09-27 {
+  revision 2024-10-30 {
     description
       "This revision adds the following new identities:
        - bandwidth-profile-type;
@@ -97,10 +97,6 @@ module ietf-te-packet-types {
    * Identities
    */
 
-  // CHANGE NOTE: The base identity bandwidth-profile-type and 
-  // its derived identities below have been
-  // added in this module revision
-  // RFC Editor: remove the note above and this note
   identity bandwidth-profile-type {
     description
       "Bandwidth Profile Types";
@@ -130,19 +126,8 @@ module ietf-te-packet-types {
         "RFC 2698: A Two Rate Three Color Marker";
     }
 
-    identity rfc-4115 {
-      base bandwidth-profile-type;
-      description
-        "RFC 4115 Bandwidth Profile";
-      reference
-        "RFC 4115: A Differentiated Service Two-Rate, Three-Color 
-                   Marker with Efficient Handling of in-Profile
-                   Traffic";
-    }
+  // Derived identities from te-types:link-metric-type
 
-    // CHANGE NOTE: The identity link-metric-delay-variation
-    // below has been added in this module revision
-    // RFC Editor: remove the note above and this note
     identity link-metric-delay-variation {
       base te-types:link-metric-type;
       description
@@ -155,9 +140,6 @@ module ietf-te-packet-types {
                    Section 4.3";
     }
 
-    // CHANGE NOTE: The identity link-metric-loss below has 
-    // been added in this module revision
-    // RFC Editor: remove the note above and this note
     identity link-metric-loss {
       base te-types:link-metric-type;
       description
@@ -170,9 +152,8 @@ module ietf-te-packet-types {
                    Section 4.4";
     }
 
-    // CHANGE NOTE: The identity path-metric-delay-variation
-    // below has been added in this module revision
-    // RFC Editor: remove the note above and this note
+  // Derived identities from te-types:link-metric-type
+
     identity path-metric-delay-variation {
       base te-types:path-metric-type;
       description
@@ -185,9 +166,6 @@ module ietf-te-packet-types {
                    Section 3.1.2";
     }
 
-    // CHANGE NOTE: The identity path-metric-loss below has 
-    // been added in this module revision
-    // RFC Editor: remove the note above and this note
     identity path-metric-loss {
       base te-types:path-metric-type;
       description
@@ -376,11 +354,11 @@ module ietf-te-packet-types {
           reference
             "RFC 7471: OSPF Traffic Engineering (TE) Metric
                        Extensions
+             RFC 8570: IS-IS Traffic Engineering (TE) Metric
+                       Extensions
              RFC 7823: Performance-Based Path Selection for
                        Explicitly Routed Label Switched Paths (LSPs)
-                       Using TE Metric Extensions
-             RFC 8570: IS-IS Traffic Engineering (TE) Metric
-                       Extensions";
+                       Using TE Metric Extensions";
         }
         leaf one-way-packet-loss {
           type decimal64 {
@@ -403,11 +381,11 @@ module ietf-te-packet-types {
           reference
             "RFC 7471: OSPF Traffic Engineering (TE) Metric
                        Extensions
+             RFC 8570: IS-IS Traffic Engineering (TE) Metric
+                       Extensions
              RFC 7823: Performance-Based Path Selection for
                        Explicitly Routed Label Switched Paths (LSPs)
-                       Using TE Metric Extensions
-             RFC 8570: IS-IS Traffic Engineering (TE) Metric
-                       Extensions";
+                       Using TE Metric Extensions";
         }
         description
           "PM one-way packet-specific augmentation for a generic PM
@@ -430,11 +408,11 @@ module ietf-te-packet-types {
           reference
             "RFC 7471: OSPF Traffic Engineering (TE) Metric
                        Extensions
+             RFC 8570: IS-IS Traffic Engineering (TE) Metric
+                       Extensions
              RFC 7823: Performance-Based Path Selection for
                        Explicitly Routed Label Switched Paths (LSPs)
-                       Using TE Metric Extensions
-             RFC 8570: IS-IS Traffic Engineering (TE) Metric
-                       Extensions";
+                       Using TE Metric Extensions";
         }
         leaf two-way-max-delay {
           type uint32 {
@@ -452,11 +430,11 @@ module ietf-te-packet-types {
           reference
             "RFC 7471: OSPF Traffic Engineering (TE) Metric
                        Extensions
+             RFC 8570: IS-IS Traffic Engineering (TE) Metric
+                       Extensions
              RFC 7823: Performance-Based Path Selection for
                        Explicitly Routed Label Switched Paths (LSPs)
-                       Using TE Metric Extensions
-             RFC 8570: IS-IS Traffic Engineering (TE) Metric
-                       Extensions";
+                       Using TE Metric Extensions";
         }
         leaf two-way-delay-variation {
           type uint32 {
@@ -477,11 +455,11 @@ module ietf-te-packet-types {
           reference
             "RFC 7471: OSPF Traffic Engineering (TE) Metric
                        Extensions
-             RFC 7823: Performance-Based Path Selection for
-                       Explicitly Routed Label Switched Paths (LSPs) 
-                       Using TE Metric Extensions
              RFC 8570: IS-IS Traffic Engineering (TE) Metric
-                       Extensions";
+                       Extensions
+             RFC 7823: Performance-Based Path Selection for
+                       Explicitly Routed Label Switched Paths (LSPs)
+                       Using TE Metric Extensions";
         }
         leaf two-way-packet-loss {
           type decimal64 {
@@ -504,13 +482,11 @@ module ietf-te-packet-types {
           "PM two-way packet-specific augmentation for a generic PM
            grouping.";
         reference
-            "RFC 7471: OSPF Traffic Engineering (TE) Metric
-                       Extensions
-             RFC 7823: Performance-Based Path Selection for
-                       Explicitly Routed Label Switched Paths (LSPs)
-                       Using TE Metric Extensions
-             RFC 8570: IS-IS Traffic Engineering (TE) Metric
-                       Extensions";
+          "RFC 7471: OSPF Traffic Engineering (TE) Metric Extensions
+           RFC 8570: IS-IS Traffic Engineering (TE) Metric Extensions
+           RFC 7823: Performance-Based Path Selection for Explicitly
+                     Routed Label Switched Paths (LSPs) Using TE
+                     Metric Extensions";
       }
     }
   }
@@ -555,10 +531,6 @@ module ietf-te-packet-types {
     }
   }
 
-  // CHANGE NOTE: The grouping 
-  // one-way-performance-metrics-gauge-packet has been added in
-  // this module revision
-  // RFC Editor: remove the note above and this note
   grouping one-way-performance-metrics-gauge-packet {
     description
       "One-way packet PM throttle grouping.
@@ -642,10 +614,6 @@ module ietf-te-packet-types {
     }
   }
 
-  // CHANGE NOTE: The grouping 
-  // two-way-performance-metrics-gauge-packet has been added in
-  // this module revision
-  // RFC Editor: remove the note above and this note
   grouping two-way-performance-metrics-gauge-packet {
     description
       "Two-way packet PM throttle grouping.
@@ -714,9 +682,6 @@ module ietf-te-packet-types {
     }
   }
 
-  // CHANGE NOTE: The bandwidth-profile-parameters below has been
-  // added in this module revision
-  // RFC Editor: remove the note above and this note
   grouping bandwidth-profile-parameters {
     description
       "Common parameters to define bandwidth profiles in packet
@@ -759,9 +724,6 @@ module ietf-te-packet-types {
     }
   }
 
-  // CHANGE NOTE: The te-packet-path-bandwidth below has been
-  // added in this module revision
-  // RFC Editor: remove the note above and this note
   grouping te-packet-path-bandwidth {
     description
       "Bandwidth attributes for TE Packet paths.";
@@ -831,9 +793,6 @@ module ietf-te-packet-types {
     }
   }
 
-  // CHANGE NOTE: The te-packet-path-bandwidth below has been
-  // added in this module revision
-  // RFC Editor: remove the note above and this note
   grouping te-packet-link-bandwidth {
     description
       "Bandwidth attributes for Packet TE links.";