Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrapStore tabs.query has extra argument #275

Open
alexelisenko opened this issue Nov 17, 2021 · 0 comments
Open

wrapStore tabs.query has extra argument #275

alexelisenko opened this issue Nov 17, 2021 · 0 comments

Comments

@alexelisenko
Copy link

I am seeing an error when running in chrome:

Uncaught (in promise) Error: Expected at most 1 argument for query(), got 2. It looks like this line here:

https://github.com/tshaddix/webext-redux/blob/master/src/wrap-store/wrapStore.js#L166

it's trying to supply a callback function, but browser.tabs.query does not take any callback parameters and instead returns a promise.

I think that call to tabs.query needs to use .then() instead, unless I'm missing something?

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/tabs/query

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant