Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of sample nodes under an edge #148

Open
savitakartik opened this issue Apr 15, 2024 · 1 comment
Open

Number of sample nodes under an edge #148

savitakartik opened this issue Apr 15, 2024 · 1 comment

Comments

@savitakartik
Copy link
Collaborator

savitakartik commented Apr 15, 2024

On the Edges tab, we could show the number of descendants for an edge, in the way that we do for mutations. (@fbaumdicker, do correct me if I have not understood your suggestion correctly!) 

As @jeromekelleher pointed out, this should be doable but not too trivial as the sets of sample nodes in the 'sub-clades' subtended by an edge might vary along the edge. 

On the UI side, we could either change line thickness (not sure if this would show up nicely in the datashaded plot but could do when we have less than a certain number of edges in the frame). Or we could display this information on click of an edge.

@fbaumdicker
Copy link
Member

Yes, that was what I was thinking about. Changing the color shading instead of thickness might also work.
However, I did not think of the issue of varying sample nodes along the same edge. Maybe a mean value works for the start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants