Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convenience function that preprocesses a TS then serves the app #211

Open
duncanMR opened this issue Oct 22, 2024 · 5 comments
Open

Comments

@duncanMR
Copy link
Contributor

The preprocessing approach is working a lot better than previous versions in the GEL research environment with terrible performance. My only concern with the new workflow is that I always want to serve the app when I preprocess a TS, so having to run the preprocess command, then copy the serve command and paste it into the shell is a bit inconvenient. This is particularly true with the awful shell performance in GEL, where each step takes a while to complete. I would find it very helpful to have an additional command that combines them, if that doesn't go against the new paradigm too much?

@jeromekelleher
Copy link
Member

Don't see any reason not to. Suggestions for names and semantics?

@benjeffery
Copy link
Member

How about a --preprocess option to serve?

@jeromekelleher
Copy link
Member

Which writes the .tsbrowse file by appending the suffix to the input path? SGTM

@benjeffery
Copy link
Member

Yeah, that's the default behaviour of preprocess, we'd match that.

@duncanMR
Copy link
Contributor Author

That sounds great to me: thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants