Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample_as_parent in variational_gamma #394

Open
hyanwong opened this issue Jun 4, 2024 · 3 comments
Open

sample_as_parent in variational_gamma #394

hyanwong opened this issue Jun 4, 2024 · 3 comments

Comments

@hyanwong
Copy link
Member

hyanwong commented Jun 4, 2024

One of the tests for the inside_outside method is test_sample_as_parent_fails. Can we actually date samples that have descendant undated nodes using the current variational_gamma implementation, or should we be failing in this case too, @nspope ?

@nspope
Copy link
Contributor

nspope commented Jun 4, 2024

The machinery is (mostly) there but it's not working yet. Do we need to add an exception so that it errors out appropriately?

@hyanwong
Copy link
Member Author

hyanwong commented Jun 4, 2024

Right, I guess it would be helpful to error out, but it's not a high priority. Does the same go for non-contemporary samples?

@nspope
Copy link
Contributor

nspope commented Jun 4, 2024

Yup, same deal -- EP machinery in place, but rescaling routine doesn't do the right thing yet (although it's conceptually very straightforward to incorporate). Not going to worry about getting all that sorted out until we have a solid application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants