Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not append None to all reported SampleData allele lists? #894

Open
hyanwong opened this issue Jan 24, 2024 · 0 comments
Open

Why not append None to all reported SampleData allele lists? #894

hyanwong opened this issue Jan 24, 2024 · 0 comments

Comments

@hyanwong
Copy link
Member

In various places in tsinfer we try to work out if a site contains missing data, and if so, we append a None to the alleles list, so that if we access into the list, we get a None out.

Sorting out the logic of whether a site has missing data leads to some extra complex code. Why don;t we simply add a None to all allele lists, so that the number of alleles is always the size of the list minus 1? What are the downsides to that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant