Add a sample_id column to ancestors #607
Conversation
Codecov Report
@@ Coverage Diff @@
## main #607 +/- ##
=======================================
Coverage 93.11% 93.11%
=======================================
Files 17 17
Lines 5155 5155
Branches 959 959
=======================================
Hits 4800 4800
Misses 235 235
Partials 120 120
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hyanwong
force-pushed
the
save-sample-ids
branch
from
2647e3e
to
1c2de8f
Compare
hyanwong
force-pushed
the
save-sample-ids
branch
from
1c2de8f
to
6d090fd
Compare
|
While we in tsinfer land, do you think we could merge this too @jeromekelleher ? What's the deal with the format spec ID changes - do we make point changes or make a full integer change? |
Starts to address tskit-dev#604. Also changes the sampledata format
hyanwong
force-pushed
the
save-sample-ids
branch
from
6d090fd
to
78d15c1
Compare
|
We don't want to invalidate all existing AncestorData files - needs to take into account this column potentially being missing and needs to test for that (== complicated). Is there a direct downstream need for this? |
|
If we are making backwards-incompatible changes, I think this is a relatively simple addition to make, and will enable matching to actual samples, which is useful e.g. for viral trees. Personally I think it worth including in https://github.com/tskit-dev/tsinfer/milestone/3 but happy to chat about it further. |
|
After discussion we decided to look at this after investigating the option of adding a |
Starts to address #604. Also changes the sampledata format to 3.1. We don't actually do anything with the stored IDs yet, though!