Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant compress() in backwards algorithm #2803

Open
jeromekelleher opened this issue Jul 18, 2023 · 0 comments
Open

Remove redundant compress() in backwards algorithm #2803

jeromekelleher opened this issue Jul 18, 2023 · 0 comments
Assignees

Comments

@jeromekelleher
Copy link
Member

In #2799 we added an initial version of the backwards algorithm, but ended up including two calls to compress() per site. This is because we need to call compress immediately before storing the ValueTransitions, because we rely on the ValueTransitions being listed in tree-preorder for downstream algorithms (like decode()). We also needed to filter out node=-1 values on the first site in the backward matrix (but that's easy enough to solve).

This is surely unnecessary, and there must be a way in which we can avoid having two calls to compress.

@jeromekelleher jeromekelleher self-assigned this Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant