Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_pbs and test #2749

Closed
wants to merge 1 commit into from
Closed

add_pbs and test #2749

wants to merge 1 commit into from

Conversation

atongsa
Copy link

@atongsa atongsa commented Apr 30, 2023

Description

add a PBS function to test population local adaptation;
solve the issue #2717;

Fixes #(2717) <- Putting the issue number here will auto-close the issue when this PR is merged

PR Checklist:

  • Tests that fully cover new/changed functionality.
  • Documentation including tutorial content if appropriate.
  • Changelogs, if there are API changes.

@atongsa
Copy link
Author

atongsa commented Apr 30, 2023

add function and test of pbs

@codecov
Copy link

codecov bot commented Apr 30, 2023

Codecov Report

Merging #2749 (e5c2fa4) into main (7ddcc95) will decrease coverage by 13.31%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2749       +/-   ##
===========================================
- Coverage   89.83%   76.53%   -13.31%     
===========================================
  Files          30       30               
  Lines       28612    28321      -291     
  Branches     5587     5314      -273     
===========================================
- Hits        25704    21675     -4029     
- Misses       1654     5331     +3677     
- Partials     1254     1315       +61     
Flag Coverage Δ
c-tests 86.24% <ø> (ø)
lwt-tests 80.13% <ø> (ø)
python-c-tests 67.17% <ø> (ø)
python-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ddcc95...e5c2fa4. Read the comment docs.

@jeromekelleher
Copy link
Member

Looks good, thanks @atongsa ! Looks like you're missing the changes for the actual module code in this PR though?

@benjeffery
Copy link
Member

BTW - you can push your code more than once to a PR - there's no need to create a new one.

@atongsa
Copy link
Author

atongsa commented May 4, 2023

ok

@atongsa atongsa closed this by deleting the head repository Jul 6, 2023
@jeromekelleher
Copy link
Member

Sorry we've been slow to review this PR @atongsa, it's hard to keep up sometimes. We would like to incorporate this statistic, but it will take some more work. Would you mind leaving the PR open please?

@atongsa
Copy link
Author

atongsa commented Jul 6, 2023

Sorry we've been slow to review this PR @atongsa, it's hard to keep up sometimes. We would like to incorporate this statistic, but it will take some more work. Would you mind leaving the PR open please?

actually, i am sorry
i messed my fork code and delete my branch, so this pr is closed automately;
can i reopen a new pr or how to reopen this pr

@atongsa atongsa mentioned this pull request Jul 6, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants