-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LS model refactoring #2799
LS model refactoring #2799
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2799 +/- ##
==========================================
- Coverage 89.97% 89.78% -0.19%
==========================================
Files 30 30
Lines 29322 29447 +125
Branches 5707 5731 +24
==========================================
+ Hits 26383 26440 +57
- Misses 1669 1723 +54
- Partials 1270 1284 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
@astheeggeggs I've made some progress here on refactoring the Python tree LS HMM code, mainly to deduplicate things a bit and also to remove the need for mirroring the coords of the ts. I think it's pretty close to the point where I can implement it in C. It would be helpful if you could take a look at the code at this point to see if you spot any howlers (just the test_haplotype_matching.py code, everthing else is incidental). I've made a start on refactoring the tests a bit as well, to move away from the current class-based approach where we internally iterate over a bunch of parameters, towards something that's much more modular, and where you can run a single example with a single set of parameters easily. It's a WIP though |
dca554e
to
2fdc7c6
Compare
I think this is breaking on some lshmm bugs that have been fixed, so the simplest thing is to wait for version 0.0.5 (astheeggeggs/lshmm#25) I've added a commit to bump the requirements. |
f7269b4
to
90a578a
Compare
90a578a
to
408d7e3
Compare
408d7e3
to
f41007f
Compare
Also update changed parameter names for lshmm 0.0.5
f41007f
to
64aedbf
Compare
Some refactoring of the LS hmm code. WIP
based on #2786 (so has a bunch of extra commits).