Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comma sep display numbers #3018

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Comma sep display numbers #3018

merged 1 commit into from
Oct 11, 2024

Conversation

benjeffery
Copy link
Member

Fixes #3017

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.84%. Comparing base (dca04b3) to head (fa1a9a4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3018   +/-   ##
=======================================
  Coverage   89.84%   89.84%           
=======================================
  Files          29       29           
  Lines       32097    32097           
  Branches     5756     5756           
=======================================
  Hits        28837    28837           
  Misses       1859     1859           
  Partials     1401     1401           
Flag Coverage Δ
c-tests 86.69% <ø> (ø)
lwt-tests 80.78% <ø> (ø)
python-c-tests 89.05% <ø> (ø)
python-tests 99.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/tskit/genotypes.py 99.07% <ø> (ø)
python/tskit/tables.py 98.96% <100.00%> (ø)
python/tskit/trees.py 98.80% <ø> (ø)
python/tskit/util.py 99.25% <ø> (ø)

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a bigger change than anticipated! LGTM though.

@jeromekelleher
Copy link
Member

Definitely worth a changelog entry

@benjeffery
Copy link
Member Author

Changelog added.

@benjeffery benjeffery added the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Oct 11, 2024
@mergify mergify bot merged commit 079e189 into tskit-dev:main Oct 11, 2024
21 checks passed
@mergify mergify bot removed the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Values as comma-separated thousands
2 participants