Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SVG pack_untracked_polytomies bug #3050

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

hyanwong
Copy link
Member

@hyanwong hyanwong commented Nov 6, 2024

Fixes #3049

PR Checklist:

  • Tests that fully cover new/changed functionality.
  • Changelogs, if there are API changes.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.07%. Comparing base (73ef4cc) to head (98d89d7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3050      +/-   ##
==========================================
- Coverage   89.85%   87.07%   -2.78%     
==========================================
  Files          29       11      -18     
  Lines       32128    24666    -7462     
  Branches     5763     4556    -1207     
==========================================
- Hits        28868    21478    -7390     
+ Misses       1859     1824      -35     
+ Partials     1401     1364      -37     
Flag Coverage Δ
c-tests 86.69% <ø> (ø)
lwt-tests 80.78% <ø> (ø)
python-c-tests 89.05% <ø> (ø)
python-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

python/CHANGELOG.rst Outdated Show resolved Hide resolved
@benjeffery benjeffery added the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Nov 7, 2024
@mergify mergify bot merged commit 5c6ecdb into tskit-dev:main Nov 7, 2024
20 of 21 checks passed
@mergify mergify bot removed the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Undocumented) pack_untracked_polytomies option not correctly identifying branches to pack
3 participants