Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluid Language Limitations #31

Open
PepperCode1 opened this issue Jun 11, 2021 · 0 comments
Open

Fluid Language Limitations #31

PepperCode1 opened this issue Jun 11, 2021 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@PepperCode1
Copy link

Currently, the FluidBuilder does not allow assigning translation keys or names in some situations and is inconsistent in others.

  • If a block does not exist and .lang with a translation key and name was called, the datagenned name will use the provided translation key but the fluid attributes will use the default generated translation key. I suggest that the provided translation key be used in the fluid attributes as well.
  • If a block does exist, the .lang methods on the builder become useless because the fluid's translation key will be set to the block's translation key. I suggest that in this case the .lang calls should proxy to the underlying BlockBuilder's methods or allow setting a different translation key and name than the block.
  • There is no way to make the still fluid and the flowing fluid have different translation keys or names.
@tterrag1098 tterrag1098 added the bug Something isn't working label Jun 22, 2021
@tterrag1098 tterrag1098 added this to the 1.1 milestone Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants