started unifying tracing #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmario
approved these changes
Aug 27, 2024
bmario
reviewed
Aug 28, 2024
Comment on lines
31
to
32
| inline void regionBegin(const char* const region_name); | ||
| inline void regionEnd(const char* const region_name); |
There was a problem hiding this comment.
Suggested change
| inline void regionBegin(const char* const region_name); | |
| inline void regionEnd(const char* const region_name); | |
| void regionBegin(const char* const region_name); | |
| void regionEnd(const char* const region_name); |
bmario
reviewed
Aug 28, 2024
Comment on lines
29
to
35
| inline void Tracing::regionBegin(const char* const region_name) { | ||
| // Do nothing | ||
| } | ||
|
|
||
| inline void Tracing::regionEnd(const char* const region_name) { | ||
| // Do nothing | ||
| } |
There was a problem hiding this comment.
Suggested change
| inline void Tracing::regionBegin(const char* const region_name) { | |
| // Do nothing | |
| } | |
| inline void Tracing::regionEnd(const char* const region_name) { | |
| // Do nothing | |
| } | |
| inline void Tracing::regionBegin(const char* const) { | |
| // Do nothing | |
| } | |
| inline void Tracing::regionEnd(const char* const) { | |
| // Do nothing | |
| } |
fix warnings
13 tasks
…hough not with static)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide feedback on C++ and cmake. I think all of this could be more elegant.