-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use submodule for example notebooks #148
Use submodule for example notebooks #148
Conversation
This looks good! Great to have this in there as a submodule :) One small note: the README should be updated to reflect the fact that the submodules should be initialized after pulling this repo, using (or similar): Another question: has this been tested with the online build on readthedocs? |
Hi Dominic, Thanks for the feedback, I just added the submodule instructions to the README in beeae9a :) Unfortunately I haven't tested the online build yet, I couldn't figure out how to trigger the doc builds manually for versions other than the latest and stable release. Does this need to be initiated from the readthedocs website? |
Thanks! On the readthedocs website, you can trigger the build of any branch (I think), to test if it works. I'll have a look at it in the coming days (so many pull requests to go through! :) ) |
Tested: https://docs.tudat.space/en/feature-examples-submodule/index.html Works like a charm :) |
Great to see this working as intended :) |
I have an option 'activate a version' here: https://readthedocs.org/projects/tudat-space/versions/ Where I can trigger a build for any branch or tag |
This PR replaces the local jupyter notebooks for the examples shown on the website with the tudatpy-examples repo as a submodule.
Changes made:
tudatpy-examples
as submodule.readthedocs.yml
to include all submodules when cloning the repo.rst
andconf.py
filesIf there is any feedback on the approach (see #109 for the issue and tudat-team/tudatpy-examples#13 (comment) for the proposed workflow) please let me know!
Before merging
Please review and merge #145 first, as this branch builds on top of this