Implement MSC4193 #522
Draft
Implement MSC4193 #522
+52
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to implement MSC4193 (m.spoiler) for media in Matrix.
Currently, this PR supports rendering blurred images and videos, with the html
titleset to them.spoiler.reason, and the spoiler is removed on click.It does not currently support sending spoilered media.
It would also be nice to have the spoiler reason somewhere more prominent. Perhaps a custom HTML tooltip that appears instantly rather than relying on the html title?
Screenshots: