Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release for twinby masterkatalog #49

Closed
wants to merge 8 commits into from
Closed

Conversation

MarijaKnezevic
Copy link
Collaborator

Version 1.2.2-twinby-master only for TwinBy master katalog where upload function is disabled

@MarijaKnezevic MarijaKnezevic requested a review from BWibo October 14, 2023 18:30
@BWibo
Copy link
Member

BWibo commented Oct 15, 2023

Closing.

We should not create a separate image for this, as we would have to maintain this, for eternity!
And we don't need to have a separate image/release for the master catalog!

The changes made in this PR are only configuration changes, that can be set when launching the instance.
The ckan.extraEnv feature can be used to configure this using https://github.com/tum-gis/sddi-ckan-k8s.
Here are the docs and an example:

ckan:
  extraEnv:
    CKAN_MAX_UPLOAD_SIZE_MB: "0"

@BWibo BWibo closed this Oct 15, 2023
@MarijaKnezevic
Copy link
Collaborator Author

Thank you. I will inform project participants that for the case of master catalog they need to take care of the configuration in https://github.com/tum-gis/sddi-ckan-k8s and be sure that the ckan.max_resource_size is set to zero ( ckan.max_resource_size = 0 ).

@lreneral
Copy link

@MarijaKnezevic @BWibo that means i only have to change the value of CKAN_MAX_UPLOAD_SIZE_MB to "0"!? (Right now it is 250).
And i also have to add this extra environment variable 'CKAN_MAX_RESOURCE_SIZE: "0" ' since it is not listed in the ckan-pod, right?
Image tag remains the same (sddi-pr-39-896109c), right?
Thanks in advance.

@BWibo
Copy link
Member

BWibo commented Oct 18, 2023

@lreneral No, there is going to be a new image too.
Because auf the kernel issues on your infrastructure, you will not be able to use the new image release directly. I will rebase #39 onto the new content, then you can use the new image from that PR.

@lreneral
Copy link

@BWibo OK. Im waiting for the new image to deploy.

@MarijaKnezevic MarijaKnezevic deleted the twinby-masterkatalog branch October 27, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants