Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDDI base Docker build CKAN 2.11.0 #69

Conversation

aleksandralazoroska
Copy link
Collaborator

@aleksandralazoroska aleksandralazoroska commented Oct 28, 2024

  • Updated the Dockerfile for CKAN 2.11.0
  • Added SDDI Plugins for CKAN 2.11.
  • Updated versions for uWSGI, gevent, and greenlet

@aleksandralazoroska aleksandralazoroska changed the title Feature/ckan build 2.11.0 SDDI base Docker build CKAN 2.11.0 Oct 28, 2024
@aleksandralazoroska aleksandralazoroska marked this pull request as draft October 28, 2024 13:15
@BWibo
Copy link
Member

BWibo commented Oct 28, 2024

@aleksandralazoroska
Thx for the work on the PR. I just found the time to take a quick look that lead to a question.

Is there a specific reason why are you building CKAN inside the image and not use the official base image instead?
This is a complicated task that we would have to maintain in the future.

@MarijaKnezevic
Copy link
Collaborator

Please remove ckanext-grouphierarchy L115-L126 and ckanext-composite , ckanext-repeating , ckanext-password-policy L159-L190.

Some of those plugins are either not supported in CKAN 2.11 or have been migrated to ckanext-scheme-sddi or ckanext-theme-sddi.
Please use plugins mentioned in #64

@aleksandralazoroska
Copy link
Collaborator Author

aleksandralazoroska commented Oct 29, 2024

@aleksandralazoroska Thx for the work on the PR. I just found the time to take a quick look that lead to a question.

Is there a specific reason why are you building CKAN inside the image and not use the official base image instead? This is a complicated task that we would have to maintain in the future.

@BWibo
Based on my internal alignment with @ilchebedelovski , we got issues with the Spatial and Harvest extensions when we worked on the CKAN 2.10 build using the official CKAN Docker image, that was the reason why we decided to start the build from python:3.9-slim and then install CKAN in the first build layer.

@MarijaKnezevic
Copy link
Collaborator

@aleksandralazoroska did you tried to use official base image?
As Bruno mentioned in #55 , since Debian-based images are now available, it should be possible to use official ckan base images.

We had problems with ckanext-spatial and Bruno realized that the installation requires a Debian-based image, and for that we used an image from Keitaro because at the time there was no Debian-based image of CKAN. But from CKAN 2.11. it should be possible as they are offering official CKAN Debian Based images.

The idea is to keep the maintenance effort for this development as low as possible and to use community contributions as much as possible.

@aleksandralazoroska
Copy link
Collaborator Author

Closing the PR because of auth issues on Container Registry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants