Enhanced the filter param of the table aws_ssm_inventory and fixed the error for the table aws_ssm_inventory_entry by type name #1980
Conversation
…e error for the table aws_ssm_inventory_entry by type name
…ed by user if not fall back to parent table type name we are getting.
There was a problem hiding this comment.
Functionally, this change does exactly what we hoped it would. Have already developed and tested the desired reporting functionality using this feature branch, and now only await this feature in an official release to proceed with our feature release: https://github.com/stackArmor/threatalert-security-toolbox/issues/16
|
Thank you very much, @atfurman, for taking the time to test this pull request and providing valuable feedback. I will coordinate with the team to ensure the integration of this feature. 👍 |
aws/table_aws_ssm_inventory.go
Outdated
| }, | ||
| { | ||
| Name: "application_attribute_key", | ||
| Description: "", |
There was a problem hiding this comment.
@ParthaI, Could you please add a description for the columns where it is missing?
There was a problem hiding this comment.
Added the missing description for the columns.
aws/table_aws_ssm_inventory.go
Outdated
| input := buildSSMInventoryFilter(ctx, d.Quals) | ||
|
|
||
| input := buildSSMInventoryFilter(ctx, d) | ||
| // filter := types.InventoryFilter{ |
There was a problem hiding this comment.
Please remove the commented code.
There was a problem hiding this comment.
Cleaned-up the codes.
Co-authored-by: Madhushree Ray <madhushree@turbot.com>
Integration test logs
Logs
Example query results
Results