-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ashish Malla #201
base: master
Are you sure you want to change the base?
Ashish Malla #201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid work on your prework! Be sure to check my notes and make changes.
@@ -64,3 +74,15 @@ When cupsOfFlour = 3 and hasSauce = true, your program should log "I can make pi | |||
|
|||
var cupsOfFlour = 1; | |||
var hasSauce = true; | |||
|
|||
if (cupsOfFlour == 1 && hasSauce == true) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I want you to get in the habit of is using stricly equal ===
over ==
- it's a better safeguard against any wonkiness that JS might interpret the wrong way. Please refactor these when you get a chance!
function findSum(num1, num2) { | ||
console.log(num1 + num2); | ||
} | ||
var a = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming is an important part of being a strong developer. From a developer empathy perspective, I don't understand what a
or b
means just by reading the name of your variables. A better naming convention might be number1
or num2
or firstVal
- being more semantic allows other developers to have a better understanding of the data you are working with!
// => 1, 2, Fizz, 4, Buzz, Fizz, 7, 8, Fizz, Buzz, 11, Fizz, 13, 14, FizzBuzz, ..., 98, Fizz, Buzz | ||
// ``` | ||
|
||
for (i=1; i<=100; i++){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Watch your spacing on this - from a developer empathy perspective, having no spaces between your variable names, assignment operator and value can be difficult to read.
if (i % 3 == 0 && i % 5===0 ) { | ||
console.log("FizzBuzz"); | ||
} | ||
else if (i % 3===0 ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check spacing here - good job using stricly equals!
} | ||
|
||
//Bonus: same exercise but will take any range numbers | ||
var startRange = prompt("Enter a num for starting range: "); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting use of prompt
here! Typically, you won't use these hardcoded functions (such as prompt
or alert
) and instead will build your own in Mod 1. How could you potentially use your understanding of functions + parameters to achieve the same effect?
@@ -0,0 +1,56 @@ | |||
# How I would solve Ceasar Cipher problem | |||
1. Assuming we made an object CeasarCipher object of a class, I'll make a class named CeasarCipher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is great psuedocode/plan for your approach!
4. Using for loop I will make my code read every character and convert character(capital) to its decimal value | ||
5. At the end I will use the given code to shift character by five | ||
|
||
### Solution to Ceasar Cipher problem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you find this solution somewhere or create on your own?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericweissman I'm a CIS student and I've been teaching myself Java since the quarantine started. I knew about ASCII and if-else statements and after I figure out what Ceasar Cipher is, it was pretty easy to solve it.
### Reflect: | ||
|
||
1. How you feel about asking questions? (specifically, the technical question as you enter your technical work at Turing) | ||
- When I don't know the team well I hesitate to ask questions at first. I'm still learning English, I get worried if I'm going to hold the entire class when I ask questions. Because if I'm not able to clearly ask questions then we will spend half of the time trying to figure out what I'm trying to ask. After I feel comfortable with the team, I usually find myself asking lots of questions. This is the first time I have ever felt so passionate about studying so, I'm sure I will be asking lots of questions during my time here at Turing. I've been learning different coding terms to help me able to ask questions clearly as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do NOT worry about holding anyone back or asking questions! We've worked with many students who aren't native English speakers and they have been very successful in our program. However, you'll need to be proactive in asking for help or asking your instructors to explain things differently. Trust me, your cohortmates will appreciate it too - asking questions can lead to much better understanding of concepts!
Here is my prework!