Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional variable to reply into a thread #295

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Denperidge
Copy link

I guess this would reopen and reclose #289!

Same as with my previous commit: no tests as of yet, and any help with this would be greatly appreciated. Other than that,

Checklist

  • Tests written for all new code
  • Linter has been satisfied
  • Sign-off given on the changes (see CONTRIBUTING.md)

Signed-off-by: Cat <denperidge@gmail.com>
This fixes incorrect event_id when replying to a reply in a thread

Signed-off-by: Cat <denperidge@gmail.com>
Copy link
Owner

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just visiting to say I haven't forgotten about this, but it's taking a while for me to review, sorry. The battle I'm having with myself is whether this is how thread support should be introduced, or if a different approach is needed design-wise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants