Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Sled crypto store, use SQLite by default #330

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AndrewFerr
Copy link
Contributor

@AndrewFerr AndrewFerr commented Jul 17, 2023

on account of it being removed from the crypto-sdk

Signed-off-by: Andrew Ferrazzutti andrewf@element.io

Checklist

  • Tests written for all new code
  • Linter has been satisfied
  • Sign-off given on the changes (see CONTRIBUTING.md)

@turt2live
Copy link
Owner

I'm honestly more inclined to replace the rust-sdk with something else. These zero-notice and breaking changes are becoming more hassle than it's worth.

A migration path needs to be present for this SDK to drop sled, and the SDK will need to automatically do it in order to avoid a breaking change itself.

@AndrewFerr
Copy link
Contributor Author

A migration path needs to be present for this SDK to drop sled, and the SDK will need to automatically do it in order to avoid a breaking change itself.

I've opened an issue to track this: element-hq#26

@turt2live
Copy link
Owner

It looks like the rust-sdk bindings have stablized a bit since this was opened, which is great. I'm tempted to land this in a v1.0.0 of the bot-sdk, as it's a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants