Catch when CryptoClient can't find room members #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CryptoClient#onRoomEvent may throw when looking up the members of a room with a client that isn't in the room, which can happen if appservice namespaces are broad & the appservice receives events for rooms that some of its managed clients are not members of.
because: - the failure will print its own logs - the point of catching this is that it's _not_ an error
because the failure already logs the error
turt2live
requested changes
Oct 26, 2023
src/e2ee/CryptoClient.ts
Outdated
| await this.engine.addTrackedUsers(members.map(e => e.membershipFor)); | ||
| return this.client.getRoomMembers(roomId, null, ['join', 'invite']).then( | ||
| members => this.engine.addTrackedUsers(members.map(e => e.membershipFor)), | ||
| e => void LogService.warn("CryptoClient", `Unable to get members of room ${roomId}`), |
There was a problem hiding this comment.
Ideally we use a try/catch pattern here using async/await.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CryptoClient#onRoomEvent may throw when looking up the members of a room with a client that isn't in the room, which can happen if appservice namespaces are broad & the appservice receives events for rooms that some of its managed clients are not members of.
Checklist