Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feauture Request] CLI Output #10

Open
hxr404 opened this issue Mar 12, 2021 · 7 comments
Open

[Feauture Request] CLI Output #10

hxr404 opened this issue Mar 12, 2021 · 7 comments
Labels
enhancement New feature or request
Milestone

Comments

@hxr404
Copy link

hxr404 commented Mar 12, 2021

First of all, thank you for creating this!!!!
Its really useful!
Now the Feature Request :D

Is your feature request related to a problem? Please describe.
When running it from command line, there is no output.

I'm sure that it's not a 'known-not-a-bug'
✅ Yes

Describe the solution you'd like
It would be nice if it would output some kind of status indicators e.g.
Checking for Updates (xyz)...
(xyz) is up to date! or Downloading (xyz)... Installing (xyz)... Update successfull! or Error (xyz): Error

Describe alternatives you've considered
Only having the output when using a -verbose Flag

Additional context
This is just a draft. The output could also look different, the main thing is that users see whats happening and don't just stare at a blinking cursor xD

@tushev
Copy link
Owner

tushev commented Mar 12, 2021

Hello,

Thank you for your suggestion.

Currently the updater is GUI only. I should check, whether it's possible to attach a console to the WPF app.

  • If yes, logging "status/debug" information to console is somewhat simpler
    (may think about it, definitely with a kind of -console flag).
  • Making a console-only interactive mode (without GUI interaction) will require a significant effort and is not planned in nearby future.

@tushev tushev added the enhancement New feature or request label Mar 12, 2021
@hxr404
Copy link
Author

hxr404 commented Mar 20, 2021

ok. Thank You.
If its too complicated to add a console flag, it would be enough to be able to pass custom flags to the msi Installer.

In my case I'd e.g. add the ADDLOCAL=FeatureMain INSTALLDIR=$directory /quiet /qn flag manually in config mode, so the user just has to click on Update once (in the updatewatcher's GUI) and not going through the whole MSI Installer.

@tushev
Copy link
Owner

tushev commented Mar 20, 2021

In my case I'd e.g. add the ADDLOCAL=FeatureMain INSTALLDIR=$directory /quiet /qn flag manually in config mode, so the user just has to click on Update once (in the updatewatcher's GUI) and not going through the whole MSI Installer.

That's a good idea, thank you for your suggestion! I think this will significantly improve UX.

@tushev tushev added this to the 2.0.3.0 milestone Mar 20, 2021
@hxr404
Copy link
Author

hxr404 commented Mar 29, 2021

Nice I’m looking forward to the update!
But there would be still one issue left: The MSI Installer always creates an entry in the "programs and features" list. This isn't good for portable applications that come bundled with a runtime.

This could be fixed by adding an option "Download and Extract Zip instead of Installer" that can be set in config mode. This would also fix the problem that fourth digit updates and major updates don't replace the outdated Versions

I really appreciate the effort you put into this and especially reading through all my feedback :D. Thx

@tushev
Copy link
Owner

tushev commented Mar 29, 2021

Well, it looks like I forgot to document this, but one can always download ZIPs manually using context menu in Update dialog starting from v. 2.0.0.0:

image.

and major updates doesn't replace the outdated Versions

Once AdoptOpenJDK/openjdk-api-v3#206 is closed, I will start working on a new version, that will be able to detect outdated AdoptOpenJDK versions and suggest updating to the latest (LTS) release. However, there is no due date yet.

I really appreciate the effort you put into this and especially reading through all my feedback :D. Thx

Thanks :)

@maverick74
Copy link

user just has to click on Update once (in the updatewatcher's GUI) and not going through the whole MSI Installer.

@tushev any update on this?

@tushev
Copy link
Owner

tushev commented Mar 21, 2022

@maverick74 It's in TODO list for the next release but there is no estimated date yet...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants