Fix the release artifacts workflow #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes `os.matrix` into the correct `matrix.os`.
vkleen
force-pushed
the
fix/release-workflow
branch
from
69732a9
to
c83b802
Compare
vkleen
force-pushed
the
fix/release-workflow
branch
4 times, most recently
from
05ce68e
to
08abf49
Compare
vkleen
force-pushed
the
fix/release-workflow
branch
from
08abf49
to
7981a9e
Compare
vkleen
force-pushed
the
fix/release-workflow
branch
from
7981a9e
to
cd897af
Compare
vkleen
force-pushed
the
fix/release-workflow
branch
5 times, most recently
from
241f8ca
to
65f0167
Compare
vkleen
force-pushed
the
fix/release-workflow
branch
from
65f0167
to
0ae9a35
Compare
vkleen
force-pushed
the
fix/release-workflow
branch
3 times, most recently
from
8f457c8
to
21bd76d
Compare
vkleen
force-pushed
the
fix/release-workflow
branch
from
21bd76d
to
c2c60ad
Compare
yannham
approved these changes
Sep 6, 2023
suimong
pushed a commit
to suimong/nickel
that referenced
this pull request
Sep 17, 2023
* Fix a typo in the release workflow This changes `os.matrix` into the correct `matrix.os`. * Use `nodeRuntimes` as required by nixpkgs master, now * Add nix settings to github-runner.nix * Disable diffutils tests on arm64 musl * Add dependencies on `start-runner` in `release-artifacts.yaml` * Use `--log-format raw-with-logs` like in the CI workflow * Use the correct cargo package for `nickel-static` * Adjust linker flags on arm64 musl * Add github cli and docker to `github-runner.nix` * Combine static binary and docker image building jobs for caching * Allow docker access for github jobs * Use `docker buildx` to assemble the multiplatform image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are necessary changes to the release workflow, the static binary build on arm64 and the GitHub runner infrastructure for the release artifact building to work.