Let rec patterns #2031
Let rec patterns #2031
Conversation
|
| Report | Thu, September 12, 2024 at 01:47:17 UTC |
| Project | nickel |
| Branch | 2031/merge |
| Testbed | ubuntu-latest |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!
- Latency (latency)
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) |
|---|---|---|
| fibonacci 10 | ➖ (view plot) | 487,690.00 |
| pidigits 100 | ➖ (view plot) | 3,233,900.00 |
| product 30 | ➖ (view plot) | 805,260.00 |
| scalar 10 | ➖ (view plot) | 1,474,600.00 |
| sum 30 | ➖ (view plot) | 803,210.00 |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
|
🎉 All dependencies have been resolved ! |
|
@jneem once it's rebased could please tag me, and I'll take a look! |
jneem
force-pushed
the
let-rec-patterns
branch
from
a6ceb15
to
b1611a1
Compare
jneem
force-pushed
the
let-rec-patterns
branch
from
b1611a1
to
73e7770
Compare
|
@yannham it's ready for a look |
cli/tests/snapshot/snapshots/snapshot__eval_stderr_destructuring_closed_fail.ncl.snap
Outdated
Show resolved
Hide resolved
cli/tests/snapshot/snapshots/snapshot__eval_stderr_destructuring_closed_fail.ncl.snap
Show resolved
Hide resolved
core/src/term/mod.rs
Outdated
| let attrs = LetAttrs { | ||
| binding_type: BindingType::Normal, | ||
| rec: false, | ||
| }; |
There was a problem hiding this comment.
Nitpick: I think this is the Default implementation of LetAttrs. But if you spell the values out on purpose to be more explicit that's fair too.
| let attrs = LetAttrs { | ||
| binding_type: BindingType::Normal, | ||
| rec, | ||
| }; |
core/src/typecheck/pattern.rs
Outdated
| /// The type of each "leaf" identifier will be assigned based on the `mode` | ||
| /// argument. The current possibilities are for each leaf to have type | ||
| /// `Dyn`, or to be assigned a fresh unification variable. |
There was a problem hiding this comment.
Why did this comment change? Have we changed anything about type annotations in record patterns?
There was a problem hiding this comment.
Maybe I misunderstood, but it seemed to me that the code has only two cases (Dyn for TypecheckMode::Walk, and a unification variable for TypecheckMode::Enforce). The previous comment made it sound like there were three cases.
There was a problem hiding this comment.
I think the third case is something like match x { {foo : Number, bar: String} => ...}, where we take the type from the annotation instead. Or at least so I recall.
Depends on #2010
Allows
let recbindings to contain patterns. Also fixes a bug in lsp completions, where pattern bindings were accidentally already treated as recursive.The destructuring is no longer desugared to a match block (which allows for slightly better diagnostics), but it is still as eager as a match block destructuring and it still uses the same pattern compilation under the hood. The motivations for destructuring eagerly,
let 'Foo = 'Bar in truewon't error)