Update flake inputs #2058
Merged
Update flake inputs #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bencher Report| Branch | 2058/merge |
| Testbed | ubuntu-latest |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| fibonacci 10 | 📈 view plot | 496,540.00 |
| pidigits 100 | 📈 view plot | 3,272,800.00 |
| product 30 | 📈 view plot | 841,660.00 |
| scalar 10 | 📈 view plot | 1,546,800.00 |
| sum 30 | 📈 view plot | 839,910.00 |
Update various flake inputs and the flake.lock file. Adapt the flake.nix file, as well as the Rust source code, to accomodate the latest changes (new clippy warnings, etc.). Topiary is getting hard to use from the flake, because there are two conflicting versions: the one that is pulled from Nix to be used in the CI (checking that files are properly formatted), and the one built into Nickel via cargo. Both must agree (or at least there might be a difference in formatting between the two if they aren't the same version). Since the addition of dynamic loading of grammars, latest Topiary has become harder to build from Nix. To avoid all those pitfalls, this commit gets rid of the Topiary as a flake input, and use `nickel format` instead, ensuring that the formatting is consistent. As a consequence, Topiary isn't included in the development shell anymore, but it's arguably not an issue: it was included before `nickel format`, as we needed a third party formatter, but now one can just build Nickel locally with their preferred method and use `nickel format`.
yannham
force-pushed
the
update/flake-lock
branch
from
4092f23
to
b2ac928
Compare
jneem
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update various flake inputs and the flake.lock file. Adapt the flake.nix file, as well as the Rust source code, to accomodate the latest changes (new clippy warnings, etc.).
This PR has been split off #2037, which started to mix too many concerns. The pure workflow changes are left in #2037.
Topiary is getting hard to use from the flake, because there are two conflicting versions: the one that is pulled from the flake's input to be used in the CI (checking that files are properly formatted), and the one built into Nickel via cargo. Both must agree (or at least there might be a difference in formatting between the two if they aren't the same version). Since the addition of dynamic loading of grammars, the flake input's Topiary has become harder to build from Nix, and is also failing the CI even if we don't update it because of tweag/topiary#702.
To avoid all those pitfalls, this commit gets rid of the Topiary as a flake input, and use
nickel formatinstead, ensuring that the formatting is consistent. As a consequence, Topiary isn't included in the development shell anymore, but it's arguably not an issue: it was included beforenickel format, as we needed a third party formatter, but now one can just build Nickel locally with one's preferred method and usenickel format.