Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip healthcheck api #237

Closed
wants to merge 3 commits into from
Closed

Skip healthcheck api #237

wants to merge 3 commits into from

Conversation

sbansla
Copy link
Contributor

@sbansla sbansla commented Jan 17, 2024 •
edited
Loading

Fixes

A new healthcheck api is created in oai specs we need skip that:
twilio/twilio-oai@45eef8d#diff-5d1f980b58be3379b445cfb53a6bd81ca4dd5ee457d7cd2df29348c1c5743905R35309

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

shrutiburman
shrutiburman previously approved these changes Jan 17, 2024
View reviewed changes
@sbansla sbansla dismissed shrutiburman’s stale review January 17, 2024 15:11

The merge-base changed after approval.

@sbansla sbansla closed this Jan 17, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@sbansla sbansla deleted the skip-healthcheck-api branch January 17, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrutiburman shrutiburman shrutiburman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbansla @shrutiburman