Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable preview domain in cli #239

Merged
merged 1 commit into from
Jan 25, 2024
Merged

feat: enable preview domain in cli #239

merged 1 commit into from
Jan 25, 2024

Conversation

shrutiburman
Copy link
Contributor

Fixes

A short description of what this PR does.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

Copy link

sonarcloud bot commented Jan 25, 2024

1 similar comment
Copy link

sonarcloud bot commented Jan 25, 2024

* const browser = new TwilioApiBrowser();
* expect(browser.domains.api.paths['/BulkExports/Exports/Jobs/{JobSid}']).to.exist;
* });
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we are disabling this ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The path doesnt exist right now, its undefined, I am guessing that we can enable this after one release that has preview.

@shrutiburman shrutiburman merged commit f77850f into main Jan 25, 2024
9 checks passed
@shrutiburman shrutiburman deleted the enable-preview branch January 25, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants