他ブラウザへの対応1 (#79)

* use `chrome.identity.getRedirectURL()` to generate per browser redirect url * ignore chrome key when blank * fmt
twin-te · Oct 12, 2023 · e379be8 · e379be8
1 parent 5a5fcf0
commit e379be8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/repositories/trello.ts b/src/repositories/trello.ts
@@ -22,7 +22,11 @@ export class Trello extends Repository {
         {
           url:
             'https://trello.com/1/OAuthAuthorizeToken?expiration=never' +
-            `&name=${config.trello.app_name}&scope=${config.trello.scopes}&key=${config.trello.key}&return_url=https://${chrome.runtime.id}.chromiumapp.org/`,
+            `&name=${config.trello.app_name}&scope=${
+              config.trello.scopes
+            }&key=${
+              config.trello.key
+            }&return_url=${chrome.identity.getRedirectURL()}`,
           interactive: true,
         },
         async (responseUrl) => {

diff --git a/webpack.config.ts b/webpack.config.ts
@@ -64,7 +64,9 @@ const webpackConfig: ConfigurationFactory = () => {
             const json = JSON.parse(content.toString())
             json.oauth2.client_id = config.google.client_id
             json.oauth2.scopes = config.google.scopes
-            json.key = config.key
+            if (config.key != '') {
+              json.key = config.key
+            }
             return JSON.stringify(json)
           },
         },