You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
sritchie
changed the title
"EventuallyRing is a Ring when we always convert" should pass ringLaws
"EventuallyRing is a Ring when we always convert" fails ringLaws
Dec 3, 2016
So, I think I made this issue but then found another law that needs to be
true for the mustConvert function. Not sure that group or ring can ever
satisfy that law for non trivial cases. I'll look into it.
On Fri, Dec 2, 2016 at 17:13 Sam Ritchie ***@***.***> wrote:
EventuallyTest.scala has a note about how we need a ringLawsEquiv...
well, we have this now and the tests fail sporadically.
https://github.com/twitter/algebird/pull/595/files#diff-3c8c583e075d65c668b6886111780911L31
For example:
[info] Falsified after 6 successful property evaluations.
[info] Location: (CheckProperties.scala:12)
[info] Occurred when passed generated values (
[info] arg0 = <function1>,
[info] arg1 = Right(7464),
[info] arg2 = Right(7426),
[info] arg3 = Right(2542)
[info] )
[info] Label of failing property:
[info] timesIsAssociative
It's set to monoidLaws for now. We should investigate!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#598>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEJdgeTe_NpVDxZfCAGWU19LlBV6Yujks5rEN5dgaJpZM4LDLgT>
.
EventuallyTest.scala
has a note about how we need aringLawsEquiv
... well, we have this now and the tests fail sporadically.https://github.com/twitter/algebird/pull/595/files#diff-3c8c583e075d65c668b6886111780911L31
For example:
It's set to
monoidLaws
for now. We should investigate!The text was updated successfully, but these errors were encountered: