Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple scorer updates, mostly aimed at reducing note status flipping #144

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

jbaxter
Copy link
Collaborator

@jbaxter jbaxter commented Aug 28, 2023

  1. Update the minimum LCB threshold for notes to become CRH to 0.35 from 0.32. This dramatically reduces the number of notes that become CRH due to this rule, but is necessary because notes that were becoming CRH when they had LCB intercepts between 0.32 and 0.34 were flipping back to NMR too often, so this change dramatically reduces the amount of status flipping.
  2. Update maximum note status flip rate to 0.09 from 0.15, to avoid flip-flopping note statuses after the model convergences to different local modes
  3. When running in parallel, read the data within each individual process rather than passing that dataset to each new process.
  4. Some more refactoring for clarity.

@jbaxter jbaxter merged commit 8587686 into main Aug 28, 2023
2 checks passed
@jbaxter jbaxter deleted the jbaxter/2023_08_28_scorer branch June 27, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant