Skip to content
This repository has been archived by the owner on Jan 15, 2022. It is now read-only.

Upgrade jackson and jersey #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 26 additions & 11 deletions hraven-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
<version>0.9.16-SNAPSHOT</version>
<name>hRaven - core</name>
<description>Core components of hRaven, including model classes and data access layer</description>

<properties>
<jetty.version>6.1.26</jetty.version>
</properties>
Expand Down Expand Up @@ -277,8 +277,12 @@
<groupId>oro</groupId>
<artifactId>oro</artifactId>
</exclusion>
<exclusion>
<groupId>org.codehaus.jackson</groupId>
<artifactId>jackson-mapper-asl</artifactId>
</exclusion>
</exclusions>
</dependency>
</dependency>
<dependency>
<groupId>org.apache.hbase</groupId>
<artifactId>hbase</artifactId>
Expand Down Expand Up @@ -334,23 +338,28 @@
<version>${jersey.version}</version>
</dependency>
<dependency>
<groupId>org.codehaus.jackson</groupId>
<artifactId>jackson-core-asl</artifactId>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
<version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
<version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>org.codehaus.jackson</groupId>
<artifactId>jackson-mapper-asl</artifactId>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>org.codehaus.jackson</groupId>
<artifactId>jackson-jaxrs</artifactId>
<groupId>com.fasterxml.jackson.jaxrs</groupId>
<artifactId> jackson-jaxrs-json-provider</artifactId>
<version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>org.codehaus.jackson</groupId>
<artifactId>jackson-xc</artifactId>
<groupId>com.fasterxml.jackson.module</groupId>
<artifactId>jackson-module-jaxb-annotations</artifactId>
<version>${jackson.version}</version>
</dependency>
<dependency>
Expand All @@ -370,8 +379,14 @@
<artifactId>hadoop-test</artifactId>
<version>${hadoop.version}</version>
<scope>test</scope>
<exclusions>
<exclusion>
<groupId>org.codehaus.jackson</groupId>
<artifactId>jackson-mapper-asl</artifactId>
</exclusion>
</exclusions>
</dependency>

<dependency>
<groupId>org.apache.hbase</groupId>
<artifactId>hbase</artifactId>
Expand Down
5 changes: 3 additions & 2 deletions hraven-core/src/main/java/com/twitter/hraven/AppKey.java
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,11 @@

package com.twitter.hraven;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
import org.apache.commons.lang.builder.CompareToBuilder;
import org.apache.commons.lang.builder.HashCodeBuilder;
import org.codehaus.jackson.annotate.JsonCreator;
import org.codehaus.jackson.annotate.JsonProperty;


public class AppKey implements Comparable<Object> {

Expand Down
3 changes: 2 additions & 1 deletion hraven-core/src/main/java/com/twitter/hraven/AppSummary.java
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
import java.util.HashSet;
import java.util.Set;

import org.codehaus.jackson.map.annotate.JsonSerialize;
import com.fasterxml.jackson.databind.annotation.JsonSerialize;


import com.twitter.hraven.datasource.ProcessingException;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,14 @@
import java.io.IOException;

import org.apache.hadoop.conf.Configuration;
import org.codehaus.jackson.JsonParser;
import org.codehaus.jackson.JsonToken;
import org.codehaus.jackson.map.DeserializationContext;
import org.codehaus.jackson.map.JsonDeserializer;
import org.codehaus.jackson.map.ObjectMapper;
import org.codehaus.jackson.map.deser.CustomDeserializerFactory;
import org.codehaus.jackson.map.deser.StdDeserializerProvider;
import com.fasterxml.jackson.core.JsonParser;
import com.fasterxml.jackson.core.JsonToken;
import com.fasterxml.jackson.core.Version;
import com.fasterxml.jackson.databind.DeserializationContext;
import com.fasterxml.jackson.databind.JsonDeserializer;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.module.SimpleModule;


/**
* Custom Jackson ObjectMapper factory that knows how to deserialize json back into objects. This
Expand All @@ -38,12 +39,11 @@ public class ClientObjectMapper {

public static ObjectMapper createCustomMapper() {
ObjectMapper result = new ObjectMapper();
CustomDeserializerFactory deserializerFactory = new CustomDeserializerFactory();

deserializerFactory.addSpecificMapping(Configuration.class, new ConfigurationDeserializer());
deserializerFactory.addSpecificMapping(CounterMap.class, new CounterDeserializer());

result.setDeserializerProvider(new StdDeserializerProvider(deserializerFactory));
SimpleModule module = new SimpleModule("Custom JsonDeserializer", new Version(1, 0, 0,
"FINAL", null, null));
module.addDeserializer(Configuration.class, new ConfigurationDeserializer());
module.addDeserializer(CounterMap.class, new CounterDeserializer());
result.registerModule(module);
return result;
}

Expand Down
3 changes: 2 additions & 1 deletion hraven-core/src/main/java/com/twitter/hraven/CounterMap.java
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
import java.util.NoSuchElementException;
import java.util.Set;

import org.codehaus.jackson.map.annotate.JsonSerialize;
import com.fasterxml.jackson.databind.annotation.JsonSerialize;


@JsonSerialize(
include=JsonSerialize.Inclusion.NON_NULL
Expand Down
6 changes: 3 additions & 3 deletions hraven-core/src/main/java/com/twitter/hraven/Flow.java
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
import org.apache.commons.lang.builder.CompareToBuilder;
import org.apache.commons.lang.builder.HashCodeBuilder;
import org.apache.hadoop.hbase.util.Bytes;
import org.codehaus.jackson.annotate.JsonCreator;
import org.codehaus.jackson.annotate.JsonProperty;
import org.codehaus.jackson.map.annotate.JsonSerialize;
import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.databind.annotation.JsonSerialize;

import java.util.ArrayList;
import java.util.List;
Expand Down
5 changes: 3 additions & 2 deletions hraven-core/src/main/java/com/twitter/hraven/FlowKey.java
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@

import org.apache.commons.lang.builder.CompareToBuilder;
import org.apache.commons.lang.builder.HashCodeBuilder;
import org.codehaus.jackson.annotate.JsonCreator;
import org.codehaus.jackson.annotate.JsonProperty;
import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;


public class FlowKey extends AppKey implements Comparable<Object> {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import org.apache.commons.lang.builder.CompareToBuilder;
import org.apache.commons.lang.builder.HashCodeBuilder;
import org.apache.hadoop.hbase.client.Result;
import org.codehaus.jackson.map.annotate.JsonSerialize;
import com.fasterxml.jackson.databind.annotation.JsonSerialize;


/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
package com.twitter.hraven;
import org.apache.commons.lang.builder.CompareToBuilder;
import org.apache.commons.lang.builder.HashCodeBuilder;
import org.codehaus.jackson.annotate.JsonCreator;
import org.codehaus.jackson.annotate.JsonProperty;
import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;

/**
* Represents a unique hdfs stats record
Expand Down
6 changes: 3 additions & 3 deletions hraven-core/src/main/java/com/twitter/hraven/JobDetails.java
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.hbase.client.Result;
import org.apache.hadoop.hbase.util.Bytes;
import org.codehaus.jackson.annotate.JsonCreator;
import org.codehaus.jackson.annotate.JsonProperty;
import org.codehaus.jackson.map.annotate.JsonSerialize;
import org.apache.commons.lang.NotImplementedException;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.databind.annotation.JsonSerialize;
import com.twitter.hraven.datasource.JobHistoryService;

/**
Expand Down
5 changes: 3 additions & 2 deletions hraven-core/src/main/java/com/twitter/hraven/JobId.java
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@

import org.apache.commons.lang.builder.CompareToBuilder;
import org.apache.commons.lang.builder.HashCodeBuilder;
import org.codehaus.jackson.annotate.JsonCreator;
import org.codehaus.jackson.annotate.JsonProperty;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;

/**
* Job identifier with individual elements of the jobtracker assigned ID parsed
Expand Down
5 changes: 3 additions & 2 deletions hraven-core/src/main/java/com/twitter/hraven/JobKey.java
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@

import org.apache.commons.lang.builder.CompareToBuilder;
import org.apache.commons.lang.builder.HashCodeBuilder;
import org.codehaus.jackson.annotate.JsonCreator;
import org.codehaus.jackson.annotate.JsonProperty;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;

/**
* Represents the row key for a given job. Row keys are stored as: username !
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,9 @@
*/
package com.twitter.hraven;

import org.codehaus.jackson.annotate.JsonCreator;
import org.codehaus.jackson.annotate.JsonProperty;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;

/**
* The job ID should be relatively unique, unless two clusters start at the same
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
import org.apache.commons.lang.StringUtils;
import org.apache.commons.lang.builder.CompareToBuilder;
import org.apache.commons.lang.builder.HashCodeBuilder;
import org.codehaus.jackson.map.annotate.JsonSerialize;

import com.fasterxml.jackson.databind.annotation.JsonSerialize;

/**
* The cluster + path qualifier for hdfs stats
Expand Down
8 changes: 4 additions & 4 deletions hraven-core/src/main/java/com/twitter/hraven/TaskDetails.java
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@
import org.apache.commons.lang.builder.HashCodeBuilder;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.apache.hadoop.hbase.util.Bytes;
import org.codehaus.jackson.annotate.JsonCreator;
import org.codehaus.jackson.annotate.JsonProperty;
import org.codehaus.jackson.map.annotate.JsonSerialize;


import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.databind.annotation.JsonSerialize;
import com.twitter.hraven.datasource.JobHistoryService;

/**
Expand Down
7 changes: 4 additions & 3 deletions hraven-core/src/main/java/com/twitter/hraven/TaskKey.java
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,10 @@

import org.apache.commons.lang.builder.CompareToBuilder;
import org.apache.commons.lang.builder.HashCodeBuilder;
import org.codehaus.jackson.annotate.JsonCreator;
import org.codehaus.jackson.annotate.JsonProperty;
import org.codehaus.jackson.map.annotate.JsonSerialize;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.databind.annotation.JsonSerialize;


/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*/
package com.twitter.hraven.rest;


import java.io.IOException;
import java.util.Iterator;
import java.util.Map;
Expand All @@ -23,17 +24,17 @@
import javax.ws.rs.ext.Provider;

import org.apache.hadoop.conf.Configuration;
import org.codehaus.jackson.JsonGenerator;
import org.codehaus.jackson.Version;
import org.codehaus.jackson.map.JsonSerializer;
import org.codehaus.jackson.map.ObjectMapper;
import org.codehaus.jackson.map.SerializationConfig.Feature;
import org.codehaus.jackson.map.SerializerProvider;
import org.codehaus.jackson.map.module.SimpleModule;
import org.apache.commons.lang.StringUtils;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;

import com.fasterxml.jackson.core.JsonGenerator;
import com.fasterxml.jackson.core.Version;
import com.fasterxml.jackson.databind.JsonSerializer;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.SerializerProvider;
import com.fasterxml.jackson.databind.module.SimpleModule;
import com.fasterxml.jackson.databind.SerializationFeature;
import com.google.common.base.Predicate;
import com.twitter.hraven.AppSummary;
import com.twitter.hraven.Constants;
Expand Down Expand Up @@ -65,7 +66,7 @@ public ObjectMapper getContext(Class<?> type) {

public static ObjectMapper createCustomMapper() {
ObjectMapper result = new ObjectMapper();
result.configure(Feature.INDENT_OUTPUT, true);
result.configure(SerializationFeature.INDENT_OUTPUT, true);
SimpleModule module = new SimpleModule("hRavenModule", new Version(0, 4, 0, null));
addJobMappings(module);
module.addSerializer(Flow.class, new FlowSerializer());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.apache.hadoop.hbase.HBaseConfiguration;
import org.codehaus.jackson.map.ObjectMapper;
import org.codehaus.jackson.type.TypeReference;

import com.fasterxml.jackson.core.type.TypeReference;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.twitter.hraven.Flow;
import com.twitter.hraven.JobDetails;
import com.twitter.hraven.TaskDetails;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,9 @@

import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.codehaus.jackson.type.TypeReference;


import com.fasterxml.jackson.core.type.TypeReference;
import com.twitter.hraven.util.JSONUtil;

class UrlDataLoader<T> {
Expand Down
16 changes: 7 additions & 9 deletions hraven-core/src/main/java/com/twitter/hraven/util/JSONUtil.java
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,10 @@
import java.io.PrintWriter;
import java.io.Writer;

import org.codehaus.jackson.map.DeserializationConfig;
import org.codehaus.jackson.map.ObjectMapper;
import org.codehaus.jackson.map.SerializationConfig;
import org.codehaus.jackson.type.TypeReference;

import com.fasterxml.jackson.core.type.TypeReference;
import com.fasterxml.jackson.databind.DeserializationFeature;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.SerializationFeature;
import com.twitter.hraven.ClientObjectMapper;
import com.twitter.hraven.rest.ObjectMapperProvider;

Expand All @@ -44,8 +43,8 @@ public class JSONUtil {
public static void writeJson(Writer writer, Object object) throws IOException {
ObjectMapper om = ObjectMapperProvider.createCustomMapper();

om.configure(SerializationConfig.Feature.INDENT_OUTPUT, true);
om.configure(SerializationConfig.Feature.FAIL_ON_EMPTY_BEANS, false);
om.configure(SerializationFeature.INDENT_OUTPUT, true);
om.configure(SerializationFeature.FAIL_ON_EMPTY_BEANS, false);

writer.write(om.writeValueAsString(object));
writer.write("\n");
Expand All @@ -58,8 +57,7 @@ public static void writeJson(String fileName, Object object) throws IOException

public static Object readJson(InputStream inputStream, TypeReference type) throws IOException {
ObjectMapper om = ClientObjectMapper.createCustomMapper();
om.getDeserializationConfig().set(DeserializationConfig.Feature.FAIL_ON_UNKNOWN_PROPERTIES,
false);
om.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
return om.readValue(inputStream, type);
}
}
Loading