This repository has been archived by the owner on Jan 15, 2022. It is now read-only.
Refactoring hraven for multiple sink support #102
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,172 @@ | ||
| package com.twitter.hraven; | ||
|
There was a problem hiding this comment. Need copyright header on all new files before we can accept them. |
||
|
|
||
| import java.io.DataInput; | ||
| import java.io.DataOutput; | ||
| import java.io.IOException; | ||
|
|
||
| import org.apache.hadoop.io.LongWritable; | ||
| import org.apache.hadoop.io.Writable; | ||
|
|
||
| import com.twitter.hraven.util.EnumWritable; | ||
| import com.twitter.hraven.util.Serializer; | ||
|
|
||
| /** | ||
| * | ||
| * @author angad.singh | ||
|
|
||
| * | ||
| * {@link JobFileTableMapper outputs this as value. It corresponds to the | ||
| * Put record which was earlier emitted | ||
| * | ||
| * @param <K> key type | ||
| * @param <V> type of dataValue object to be stored | ||
| */ | ||
|
|
||
| public abstract class HravenRecord<K extends Writable, V> implements Writable{ | ||
| private K key; | ||
| private RecordCategory dataCategory; | ||
| private RecordDataKey dataKey; | ||
| private V dataValue; | ||
| private Long submitTime; | ||
|
|
||
| public HravenRecord() { | ||
|
|
||
| } | ||
|
|
||
| public K getKey() { | ||
| return key; | ||
| } | ||
|
|
||
| public void setKey(K key) { | ||
| this.key = key; | ||
| } | ||
|
|
||
| public RecordCategory getDataCategory() { | ||
| return dataCategory; | ||
| } | ||
|
|
||
| public void setDataCategory(RecordCategory dataCategory) { | ||
| this.dataCategory = dataCategory; | ||
| } | ||
|
|
||
| public RecordDataKey getDataKey() { | ||
| return dataKey; | ||
| } | ||
|
|
||
| public void setDataKey(RecordDataKey dataKey) { | ||
| this.dataKey = dataKey; | ||
| } | ||
|
|
||
| public V getDataValue() { | ||
| return dataValue; | ||
| } | ||
|
|
||
| public void setDataValue(V dataValue) { | ||
| this.dataValue = dataValue; | ||
| } | ||
|
|
||
| public Long getSubmitTime() { | ||
| return submitTime; | ||
| } | ||
|
|
||
| public void setSubmitTime(Long submitTime) { | ||
| this.submitTime = submitTime; | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| final int prime = 31; | ||
| int result = 1; | ||
| result = prime * result + ((dataCategory == null) ? 0 : dataCategory.hashCode()); | ||
| result = prime * result + ((dataKey == null) ? 0 : dataKey.hashCode()); | ||
| result = prime * result + ((dataValue == null) ? 0 : dataValue.hashCode()); | ||
| result = prime * result + ((key == null) ? 0 : key.hashCode()); | ||
| result = prime * result + (int) (submitTime ^ (submitTime >>> 32)); | ||
| return result; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object obj) { | ||
| if (this == obj) { | ||
| return true; | ||
| } | ||
| if (obj == null) { | ||
| return false; | ||
| } | ||
| if (getClass() != obj.getClass()) { | ||
| return false; | ||
| } | ||
| HravenRecord other = (HravenRecord) obj; | ||
| if (dataCategory != other.dataCategory) { | ||
| return false; | ||
| } | ||
| if (dataKey == null) { | ||
| if (other.dataKey != null) { | ||
| return false; | ||
| } | ||
| } else if (!dataKey.equals(other.dataKey)) { | ||
| return false; | ||
| } | ||
| if (dataValue == null) { | ||
| if (other.dataValue != null) { | ||
| return false; | ||
| } | ||
| } else if (!dataValue.equals(other.dataValue)) { | ||
| return false; | ||
| } | ||
| if (key == null) { | ||
| if (other.key != null) { | ||
| return false; | ||
| } | ||
| } else if (!key.equals(other.key)) { | ||
| return false; | ||
| } | ||
| if (submitTime != other.submitTime) { | ||
| return false; | ||
| } | ||
| return true; | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "HravenRecord [key=" + key + ", dataCategory=" + dataCategory + ", dataKey=" + dataKey | ||
| + ", dataValue=" + dataValue + ", submitTime=" + submitTime + "]"; | ||
| } | ||
|
|
||
| @Override | ||
| public void write(DataOutput out) throws IOException { | ||
| //key | ||
| this.key.write(out); | ||
| //dataCategory | ||
| new EnumWritable(this.dataCategory).write(out); | ||
| //dataKey | ||
| this.dataKey.write(out); | ||
| //dataValue | ||
| byte[] b = Serializer.serialize(this.dataValue); | ||
| out.writeInt(b.length); | ||
| out.write(b); | ||
| //submitTime | ||
| new LongWritable(this.submitTime).write(out); | ||
| } | ||
|
|
||
| @Override | ||
| public void readFields(DataInput in) throws IOException { | ||
| //key | ||
| this.key.readFields(in); | ||
| //dataCategory | ||
| new EnumWritable(this.dataCategory).readFields(in); | ||
| //dataKey | ||
| this.dataKey.readFields(in); | ||
| //dataValue | ||
| byte[] b = new byte[in.readInt()]; | ||
| in.readFully(b); | ||
| try { | ||
| this.dataValue = (V) Serializer.deserialize(b); | ||
| } catch (ClassNotFoundException e) { | ||
| throw new RuntimeException("Failure in deserializing HravenRecord.dataValue"); | ||
| } | ||
| //submitTime | ||
| LongWritable lw = new LongWritable(); | ||
| lw.readFields(in); | ||
| this.submitTime = lw.get(); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| package com.twitter.hraven; | ||
|
|
||
| /** | ||
| * | ||
| * @author angad.singh | ||
|
There was a problem hiding this comment. drop author, add head to all files please. |
||
| * | ||
| * {@link JobFileTableMapper} outputs this as key. It corresponds to the | ||
| * Hbase table which was earlier emitted | ||
| */ | ||
|
|
||
| public enum HravenService { | ||
| JOB_HISTORY_RAW { | ||
| @Override | ||
| public HravenRecord getNewRecord() { | ||
| return new JobHistoryRawRecord(); | ||
| } | ||
| }, | ||
| JOB_HISTORY { | ||
| @Override | ||
| public HravenRecord getNewRecord() { | ||
| return new JobHistoryRecord(); | ||
| } | ||
| }, | ||
| JOB_HISTORY_TASK { | ||
| @Override | ||
| public HravenRecord getNewRecord() { | ||
| return new JobHistoryTaskRecord(); | ||
| } | ||
| }; | ||
|
|
||
| public abstract HravenRecord getNewRecord(); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding additional (optional) support sounds great. Here it looks like you are making a graphite sink the default.