Skip to content
This repository has been archived by the owner on Jan 15, 2022. It is now read-only.

Prefix hraven to all hbase tables #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

angadsingh
Copy link

Useful to namespace hraven tables separately in a production hbase cluster.

@vrushalic
Copy link
Collaborator

While I agree that this is a good idea to prefix tablenames, I am thinking about existing deployments of hRaven that already have tables without the prefix in production. I am wondering if we can provide the namespace name along with the dot as an argument to create_table and to the code so that the default can stay as blank at https://github.com/twitter/hraven/blob/master/hraven-core/src/main/java/com/twitter/hraven/Constants.java#L44 and still allow us the flexibility of passing it in to support the namespace classification for table names..

@jrottinghuis
Copy link
Contributor

Agreed, we had the same discussion when we went into production, we wanted to change to have the prefix. We did not want to break backwards compatibility. Having an optional flag to add the "namespace" prefix would be great. We might even do the same internally and take the hit to rename the tables.

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Angad Singh seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants