Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrooge-generator: Give @Deprecated for scala, as thrift for java does #279

Open
tomykaira opened this issue Oct 12, 2017 · 3 comments
Open

Comments

@tomykaira
Copy link

One line summary of the issue here.

Expected behavior

When "deprecated" annotation is given, the field has @Deprecated annotation in generated scala file.

Actual behavior

Nothing happens.

Steps to reproduce the behavior

Prepare thrift file like this.

struct Foo {
  1: optional i32
      bar (
        deprecated = "true",
      )
}

Compile it.

  def bar: _root_.scala.Option[Int]

Definition of bar appears, but it does not have @Deprecated annotation.

I expect something like

  @Deprecated
  def bar: _root_.scala.Option[Int]

Reference

https://issues.apache.org/jira/browse/THRIFT-640

@mosesn
Copy link
Contributor

mosesn commented Oct 12, 2017

@tomykaira so right now we're using libthrift 0.5.0 and we don't support a ton of 0.10.0 features. However, I think it would be safe to add this feature, so I think it's a good idea. Would you be interested in trying to add this feature?

@kimxogus
Copy link

Can you support this feature?

@jyanJing
Copy link
Contributor

Hi @kimxogus , afaik, we don't have plans to support this feature right now, but this is definitely something nice to have. Would you be interested in trying to add this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants