kadm: add func to decode AuthorizedOperations #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The authorized operations is an int32 bitfield that represents ACL operations. This commit adds a func that allows to decode the bitfield into a slice of kmsg.ACLOperation values. This bitfield is used in the metadata, describe clusters and describe groups API responses.
twmb
reviewed
Jan 8, 2025
pkg/kadm/acls.go
Outdated
| // - Cluster Operations: Retrieved via the DescribeCluster API or older Metadata API versions (v8–v10). | ||
| // - Topic Operations: Retrieved via the Metadata API when `IncludeTopicAuthorizedOperations` is set. | ||
| // - Group Operations: Retrieved in the DescribeGroups API response. | ||
| func DecodeACLOperations(bitfield int32) []kmsg.ACLOperation { |
There was a problem hiding this comment.
Can this return an ACLOperation, from this package? It's a type alias, so I think only this line needs to change.
There was a problem hiding this comment.
I plan to have a follow up PR that adds authorized operations fields to this package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The authorized operations is an int32 bitfield
that represents ACL operations. This commit adds
a func that allows to decode the bitfield into
a slice of kmsg.ACLOperation values. This bitfield
is used in the metadata, describe clusters and
describe groups API responses.
Fixes #869