Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap FA icons in <button> #39

Open
TheTeaCat opened this issue Jul 10, 2022 · 1 comment
Open

Wrap FA icons in <button> #39

TheTeaCat opened this issue Jul 10, 2022 · 1 comment
Labels
accessibility Something's not accessible
Milestone

Comments

@TheTeaCat
Copy link
Member

There's a lot of places where buttons are actually just FA icons with tabindexes set on them. These should really be wrapped in a button.

#34 (comment)

@TheTeaCat TheTeaCat added this to the v1.1.0 milestone Jul 10, 2022
@freddyheppell
Copy link
Member

Also, the colour themes picker should just use normal radio buttons. I'd suggest either styling the radio buttons to be black and white, or using hidden radio buttons which are still visible to screenreaders and then fa icons to indicate the status of the hidden radio button.

@TheTeaCat TheTeaCat added the accessibility Something's not accessible label Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Something's not accessible
Projects
None yet
Development

No branches or pull requests

2 participants