Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to custom exceptions #8

Open
txomon opened this issue Jul 12, 2018 · 0 comments
Open

Change to custom exceptions #8

txomon opened this issue Jul 12, 2018 · 0 comments
Labels
good first issue Good for newcomers kind/I&C Code, Infrastructure, Tests, everything that is not feature related, but more code related size/S T-shit size for tasks that take less than a day type/enhancement New feature or improvement that doesn't add value to final user

Comments

@txomon
Copy link
Owner

txomon commented Jul 12, 2018

Right now, we are using ValueError everywhere as internal exceptions. This has a few problems:

  • When testing, if we are looking for a ValueError (meaning we are testing a failing case) and get an actual ValueError (we are accessing a type the wrong way), the test will pass, but we will miss the difference
  • When retrying, retries can mask our errors instead of exposing it the first time.
@txomon txomon added type/enhancement New feature or improvement that doesn't add value to final user good first issue Good for newcomers kind/I&C Code, Infrastructure, Tests, everything that is not feature related, but more code related labels Jul 12, 2018
@txomon txomon added the size/S T-shit size for tasks that take less than a day label Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/I&C Code, Infrastructure, Tests, everything that is not feature related, but more code related size/S T-shit size for tasks that take less than a day type/enhancement New feature or improvement that doesn't add value to final user
Projects
None yet
Development

No branches or pull requests

1 participant