Skip to content

Commit

Permalink
chore(popover): fixing issues brought up in PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
nickonometry committed Feb 28, 2024
1 parent e585345 commit 46159c5
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/dev/pages/popover/popover.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
title: 'Popover',
includePath: './pages/popover/popover.ejs',
options: [
{ type: 'text-field', inputType: 'number', id: 'opt-delay', label: 'Delay', defaultValue: 0 },
{ type: 'text-field', inputType: 'number', id: 'opt-hover-delay', label: 'Hover Delay', defaultValue: 0 },
{
type: 'select',
label: 'Placement',
Expand Down
2 changes: 1 addition & 1 deletion src/dev/pages/popover/popover.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import '@tylertech/forge/checkbox';
import '@tylertech/forge/label';
import './popover.scss';

const delayInput = document.querySelector('#opt-delay') as HTMLInputElement;
const delayInput = document.querySelector('#opt-hover-delay') as HTMLInputElement;
const popover = document.querySelector('#my-popover') as IPopoverComponent;
const showPopoverButton = document.querySelector('#popover-trigger') as HTMLButtonElement;
const closeButton = document.querySelector('#close-button') as HTMLButtonElement;
Expand Down
2 changes: 1 addition & 1 deletion src/lib/popover/popover-foundation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ export class PopoverFoundation extends BaseClass implements IPopoverFoundation {
}
if (this._hoverDelay) {
this._hoverTimeout = window.setTimeout(() => {
this._openPopover();
this._openPopover();
}, this._hoverDelay);
} else {
this._openPopover();
Expand Down

0 comments on commit 46159c5

Please sign in to comment.